RFR: 8256614: AArch64: Add SVE backend implementation for integer min/max [v2]
Xiaohong Gong
xgong at openjdk.java.net
Mon Nov 23 09:05:57 UTC 2020
On Mon, 23 Nov 2020 08:56:34 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Minor fine-tune the basic type check
>
> Marked as reviewed by adinn (Reviewer).
> > Yeah, I agree that it's better to adjust the loop count for jtreg tests if necessary. Do you think it's better to change it with another patch since I think it's not a SVE special case (NEON and X86 have the same issue)? Changing the default loop count for all tests needs more time to run the tests and make the tests easier to time out. And I've no idea about how to set the suitable value to balance the time and effectiveness. I think some cases can actually trigger the C2 compilation if using default iterations=100. However, it cannot for simple cases like min/max.
>
> Yes, please raise a separate patch for the iteration count change. We can discuss the timing vs time-out issue there, including the option of splitting out simple tests that need higher counts. If you can do that then I'm happy with this patch as it is.
Sure, I will do it later then. Thanks a lot!
-------------
PR: https://git.openjdk.java.net/jdk/pull/1337
More information about the hotspot-compiler-dev
mailing list