RFR: 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE [v2]

Vladimir Kozlov kvn at openjdk.java.net
Mon Nov 23 16:03:57 UTC 2020


On Mon, 23 Nov 2020 07:39:28 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Why to run test code if you know the result will not match? Why not just skip testing?
>> I thought about using `@requires vm.cpu.features` checks but your check in main() is simpler and more clear.
>
> Which way you'd like me to move with this, @vnkozlov? :) I am fine with either way, leaning towards what we already have.

What I meant is to run tests only if SSE is used:
if (expectStableFloats) {
    testFloat();
}
if (expectStableDoubles) {
    testDouble();
}

-------------

PR: https://git.openjdk.java.net/jdk/pull/1187


More information about the hotspot-compiler-dev mailing list