RFR: 8256857: ARM32 builds broken after JDK-8254231 [v3]

Aleksey Shipilev shade at openjdk.java.net
Mon Nov 23 18:25:57 UTC 2020


On Mon, 23 Nov 2020 15:17:30 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>>> Though, note that the style guide asks to prefer `nullptr` to `NULL`: https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md#nullptr
>> 
>> Fixed. Please push your Zero integration first, and then I rebase this one?
>
> @shipilev Done. Though I'm not a `jdk` Reviewer, so another review is needed for this PR.
> 
> But, as the person most familiar with the code, it looks good to me.

Thanks @JornVernee, no problem. Anyone to formally ack this? Let's unbreak more builds!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1383


More information about the hotspot-compiler-dev mailing list