RFR: 8256508: Improve CompileCommand flag [v2]
Nils Eliasson
neliasso at openjdk.java.net
Tue Nov 24 13:22:12 UTC 2020
> The current implementation of compile command has two types of options. Types pre-defined options like "compileonly" and the general 'option' type.
>
> 'option'-type are not defined, they can accidentally be used with the wrong value type, and the syntax is prone to error.
>
> By pre-defining all compile commands used and giving them types the parsing can be simplified, proper parsing errors can be given and and reasonable syntax can be used.
>
> This:
> -XX:CompileCommand=option,java/util/String.toString,int,RepeatCompilation,5
>
> Is superseded by:
> -XX:CompileCommand=RepeatCompilation,java/util/String.toString,5
>
> Attention check: Did you spot the error in the old command?
>
> In order not to break anything - the old syntax is kept for now. But even the old command format is improved with verification for the option name and the type of the value.
Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision:
Exclude option is handled in compilecommand_compatibility_init
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1276/files
- new: https://git.openjdk.java.net/jdk/pull/1276/files/92eec9d6..8f97b57b
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1276&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1276&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/1276.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1276/head:pull/1276
PR: https://git.openjdk.java.net/jdk/pull/1276
More information about the hotspot-compiler-dev
mailing list