RFR: 8256508: Improve CompileCommand flag [v3]

[Vladimir Kozlov]

On Tue, 24 Nov 2020 14:34:11 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> The current implementation of compile command has two types of options. Types pre-defined options like "compileonly" and the general 'option' type.
>> 
>> 'option'-type are not defined, they can accidentally be used with the wrong value type, and the syntax is prone to error.
>> 
>> By pre-defining all compile commands used and giving them types the parsing can be simplified, proper parsing errors can be given and and reasonable syntax can be used.
>> 
>> This:
>> -XX:CompileCommand=option,java/util/String.toString,int,RepeatCompilation,5
>> 
>> Is superseded by:
>> -XX:CompileCommand=RepeatCompilation,java/util/String.toString,5
>> 
>> Attention check: Did you spot the error in the old command?
>> 
>> In order not to break anything - the old syntax is kept for now. But even the old command format is improved with verification for the option name and the type of the value.
>
> Nils Eliasson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
> 
>  - Merge branch 'master' into improve_compile_command
>  - Exclude option is handled in compilecommand_compatibility_init
>  - Make tests debug only
>  - Fix typos
>  - remove typo
>  - Fix CompilerConfigFileWarning test
>  - Fix test
>  - Merge branch 'master' of https://github.com/openjdk/jdk into improve_compile_command
>  - Fixed messages and help text
>  - Clean up error reporting
>  - ... and 7 more: https://git.openjdk.java.net/jdk/compare/7b3d0958...1995972f

Please, run pre-integration testing before push.
Latest update is fine to me but I am concern that GIT testing has failures in builds.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1276