RFR: 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64

Tobias Hartmann thartmann at openjdk.java.net
Wed Nov 25 08:23:57 UTC 2020


On Tue, 24 Nov 2020 15:31:39 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> The bug was found while I was learning @iwanowww 's patch [1].
> 
> As we know, the slot-size is 32-bit and the registers are 64-bit on AMD64.
> So RegisterImpl::max_slots_per_register [2] should be 2 on AMD64.
> 
> It would be better to fix it.
> 
> Testing:
>   - tier1~3 on Linux/x64
> 
> Thanks.
> Best regards,
> Jie
> 
> [1] https://github.com/openjdk/jdk/pull/1132
> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/register_x86.hpp#L53

Marked as reviewed by thartmann (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1413


More information about the hotspot-compiler-dev mailing list