Integrated: 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64
Jie Fu
jiefu at openjdk.java.net
Thu Nov 26 02:45:55 UTC 2020
On Tue, 24 Nov 2020 15:31:39 GMT, Jie Fu <jiefu at openjdk.org> wrote:
> Hi all,
>
> The bug was found while I was learning @iwanowww 's patch [1].
>
> As we know, the slot-size is 32-bit and the registers are 64-bit on AMD64.
> So RegisterImpl::max_slots_per_register [2] should be 2 on AMD64.
>
> It would be better to fix it.
>
> Testing:
> - tier1~3 on Linux/x64
>
> Thanks.
> Best regards,
> Jie
>
> [1] https://github.com/openjdk/jdk/pull/1132
> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/register_x86.hpp#L53
This pull request has now been integrated.
Changeset: b1d14993
Author: Jie Fu <jiefu at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/b1d14993
Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod
8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64
Reviewed-by: thartmann, vlivanov
-------------
PR: https://git.openjdk.java.net/jdk/pull/1413
More information about the hotspot-compiler-dev
mailing list