RFR: 8256757: Incorrect MachCallRuntimeNode::ret_addr_offset() for CallLeafNoFP on x86_32

Jie Fu jiefu at openjdk.java.net
Thu Nov 26 14:29:54 UTC 2020


On Thu, 26 Nov 2020 14:07:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> > How about replacing '5' with 'NativeCall::instruction_size' and also keeping the code generation order like this:
> > return pre_call_resets_size() + (_leaf_no_fp ? 0 : sizeof_FFree_Float_Stack_All) + NativeCall::instruction_size;
> 
> New style follows what is done for `MachCallDynamicJavaNode` and `MachCallStaticJavaNode`. I'd prefer to make this a targeted fix not to risk more regressions.

Okay, I see. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1452


More information about the hotspot-compiler-dev mailing list