RFR: 8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails

Andrew Dinn adinn at openjdk.java.net
Thu Nov 26 16:41:55 UTC 2020


On Wed, 25 Nov 2020 14:06:32 GMT, Andrew Haley <aph at openjdk.org> wrote:

> The problem is that the caller's expression SP is restored before throw_delayed_StackOverflowError() gets called. This is wrong: it leaves ESP pointing into the caller's frame, and this triggers an assert failure. The fix here delays updating ESP until we know we're not going to call throw_delayed_StackOverflowError(). This makes the logic the same as x86.

Looks good.

-------------

Marked as reviewed by adinn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1435


More information about the hotspot-compiler-dev mailing list