RFR: 8252684: Move the AArch64 assember test under test/hotspot/gtest
Andrew Haley
aph at openjdk.java.net
Fri Nov 27 10:17:56 UTC 2020
On Fri, 27 Nov 2020 09:51:53 GMT, Nick Gasson <ngasson at openjdk.org> wrote:
> I suppose it doesn't need to generate the whole file: the Python script can just write its output to a file that gets `#include`d into `test_assembler_aarch64.cpp`.
Indeed. I did wonder about regenerating everything by running the Python script at test time, but reasoned that doing so would introduce a dependency on build tools ("as", for example) that I didn't want to have. But moving the output of aarch64_asmtest.py into a separate file is a good idea, if you like.
I'm minded to just approve this patch as it is now.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1476
More information about the hotspot-compiler-dev
mailing list