Integrated: 8252684: Move the AArch64 assember test under test/hotspot/gtest

[Nick Gasson]

On Fri, 27 Nov 2020 04:31:46 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

> There was a question on the SVE review thread on build-dev [1] a few
> months ago about why there is a Python script and test code under
> src/hotspot/cpu/aarch64. The script generates code to check the
> Assembler instruction encodings against those of the system assembler.
> The test runs every time the debug VM is started.
> 
> AFAIK there's no precedent in the rest of Hotspot for having functional
> tests that run on startup, and we have the existing gtest framework for
> testing internal C++ modules. This patch (perhaps more of an RFC) moves
> the assembler test under test/hotspot/gtest/aarch64.
> 
> The test will now run in tier1, including for release builds. The
> downside is that debug builds won't catch assembler encoding errors
> immediately on startup.
> 
> Tested by injecting an error in one of the instruction encodings and
> verifying `make test TEST="gtest"` fails.
> 
> [1] https://mail.openjdk.java.net/pipermail/build-dev/2020-August/028048.html

This pull request has now been integrated.

Changeset: c93f0a07
Author:    Nick Gasson <ngasson at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c93f0a07
Stats:     2418 lines in 6 files changed: 1187 ins; 1227 del; 4 mod

8252684: Move the AArch64 assember test under test/hotspot/gtest

Reviewed-by: aph

-------------

PR: https://git.openjdk.java.net/jdk/pull/1476