RFR: 8253644: C2: assert(skeleton_predicate_has_opaque(iff)) failed: unexpected [v2]

[Roland Westrelin]

On Mon, 30 Nov 2020 11:53:01 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add back accidentally removed execution of test2-5.
>
> Marked as reviewed by roland (Reviewer).

> Could that be improved? But as of the current implementation, the `Opaque4` node with its inputs is shared between a fast and a slow loop. So we could not remove the `Opaque4` node when either the fast or slow loop does not need it anymore while the other one does.

Right. Yes, I think it would make sense to remove the skeleton predicates that become useless. Anyway, your fix looks good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1448