RFR: 8256655: rework long counted loop handling [v4]

Roland Westrelin roland at openjdk.java.net
Mon Nov 30 15:25:01 UTC 2020


On Mon, 30 Nov 2020 10:09:28 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - test failure
>>  - Merge branch 'master' into JDK-8256655
>>  - assert fix
>>  - Merge branch 'master' into JDK-8256655
>>  - build fixes
>>  - fix trailing whitespace
>>  - fix comment
>>  - long counted loop refactoring
>
> src/hotspot/share/opto/loopnode.cpp line 1243:
> 
>> 1241:   if (x->in(LoopNode::LoopBackControl)->Opcode() == Op_SafePoint &&
>> 1242:       (iv_bt == T_INT && LoopStripMiningIter != 0) ||
>> 1243:       iv_bt == T_LONG) {
> 
> This fails to build on mac:
> 51e416a91494/workspace/open/src/hotspot/share/opto/loopnode.cpp:1241:66: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
> [2020-11-30T10:06:24,243Z]   if (x->in(LoopNode::LoopBackControl)->Opcode() == Op_SafePoint &&
> [2020-11-30T10:06:24,243Z]       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

I pushed a fix for that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1316


More information about the hotspot-compiler-dev mailing list