RFR: 8257232: CompileThresholdScaling fails to work on 32-bit platforms

[Vladimir Kozlov]

On Sat, 28 Nov 2020 23:34:23 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> CompileThresholdScaling is incorrect on 32-bit platforms.
> 
> If you run the following command on Linux-32:
> java -XX:CompileThresholdScaling=0.75 -version
> It gets the following unexpected warnings:
> intx Tier0InvokeNotifyFreqLog=32 is outside the allowed range [ 0 ... 30 ]
> intx Tier0BackedgeNotifyFreqLog=32 is outside the allowed range [ 0 ... 30 ]
> intx Tier2InvokeNotifyFreqLog=32 is outside the allowed range [ 0 ... 30 ]
> intx Tier2BackedgeNotifyFreqLog=32 is outside the allowed range [ 0 ... 30 ]
> intx Tier3InvokeNotifyFreqLog=32 is outside the allowed range [ 0 ... 30 ]
> intx Tier3BackedgeNotifyFreqLog=32 is outside the allowed range [ 0 ... 30 ]
> intx Tier23InlineeNotifyFreqLog=32 is outside the allowed range [ 0 ... 30 ]
> 
> The failure is that nth_bit(max_freq_bits) [1] = nth_bit(32) [2] = 0 on 32-bit platforms.
> So the scaling logic is wrong.
> It would be better to fix it.
> 
> Thanks.
> Best regards,
> Jie
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/compiler/compilerDefinitions.cpp#L125
> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/utilities/globalDefinitions.hpp#L973

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1499