RFR: 8257143: Enable JVMCI code installation tests on AArch64

Vladimir Kozlov kvn at openjdk.java.net
Mon Nov 30 19:47:59 UTC 2020


On Fri, 27 Nov 2020 03:56:22 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

> This set of jtreg tests test JVMCI code installation independently of
> Graal. Currently they only run on x86 as the minimal assembler required
> is only implemented for that platform. This patch implements the
> TestAssembler for AArch64 to ensure JVMCI test coverage even if the
> Graal embedded in OpenJDK is disabled/removed.

src/hotspot/cpu/aarch64/relocInfo_aarch64.hpp line 35:

> 33:     offset_unit        =  1,
> 34:     // Must be at least 1 for RelocInfo::narrow_oop_in_const.
> 35:     format_width       =  1

Did you hit an issue with  = 0? Yes, it should be 1 for 64-bit. But I surprise nobody noticed this until now. How we handled embedded narrow_oop_in_const before?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1475


More information about the hotspot-compiler-dev mailing list