RFR: 8229186: Improve error messages for TestStringIntrinsics failures [v6]

Evgeny Nikitin enikitin at openjdk.java.net
Fri Oct 2 08:50:07 UTC 2020


On Thu, 1 Oct 2020 19:43:09 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use SB to build TestStringIntrinsics message, avoid type guessing in ArrayDiff
>
> test/lib/jdk/test/lib/format/ArrayDiff.java line 81:
> 
>> 79:      * Default limits for the formatter
>> 80:      */
>> 81:     public static class Defaults {
> 
> Does it make sense to move them into Diff? Seems like very generic formatter properties to me.

I can imagine different defaults for different diff formatters, but they probably would be very similar. Let's try your
suggestion, the 81f7a9d9b88.

-------------

PR: https://git.openjdk.java.net/jdk/pull/112


More information about the hotspot-compiler-dev mailing list