RFR: 8253566: clazz.isAssignableFrom will return false for interface implementors [v2]

Nils Eliasson neliasso at openjdk.java.net
Mon Oct 5 07:33:39 UTC 2020


On Mon, 5 Oct 2020 07:15:48 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> The code pattern in the test case is optimized as a trichotomy which
>> is wrong given SubTypeCheckNode is a special kind of CmpNode that's
>> not commutative.
>
> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The pull request now
> contains three commits:
>  - comment
>  - test
>  - trichotomy opt should not be applied to subtype check

src/hotspot/share/opto/cfgnode.cpp line 818:

> 816:   if (!cmp1->is_Cmp() || !cmp2->is_Cmp()) {
> 817:     return false; // No comparison
> 818:   } else if (cmp1->Opcode() == Op_CmpF || cmp1->Opcode() == Op_CmpD ||

This table is getting rather large. Time to add an abstraction on cmp-nodes?

-------------

PR: https://git.openjdk.java.net/jdk/pull/422


More information about the hotspot-compiler-dev mailing list