RFR: 8253404: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit

[Nils Eliasson]

On Wed, 7 Oct 2020 11:41:20 GMT, Roberto Castañeda Lozano <github.com+8792647+robcasloz at openjdk.org> wrote:

> Record nodes as dead in `Node::destruct()` if their index cannot be directly reclaimed. This prevents the "Live Node
> limit exceeded limit" assertion failure by improving the accuracy of `Compile::live_nodes()` when "hook" nodes in
> `ConvI2LNode::Ideal()` are created and deleted non-consecutively.  This addition might result in multiple calls to
> `compile::record_dead_node()` for the same node (e.g. from `PhaseIdealLoop::spinup()`), but this is safe, as
> `compile::record_dead_node()` is idempotent.

Looks good.

-------------

Marked as reviewed by neliasso (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/540