RFR: 8253566: clazz.isAssignableFrom will return false for interface implementors [v2]

Evgeny Nikitin enikitin at openjdk.java.net
Fri Oct 9 10:46:23 UTC 2020


On Mon, 5 Oct 2020 07:15:48 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> The code pattern in the test case is optimized as a trichotomy which
>> is wrong given SubTypeCheckNode is a special kind of CmpNode that's
>> not commutative.
>
> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The pull request now
> contains three commits:
>  - comment
>  - test
>  - trichotomy opt should not be applied to subtype check

test/hotspot/jtreg/compiler/types/TestSubTypeCheckMacroTrichotomy.java line 47:

> 45:
> 46:     private static int test(Class<?> c1, Class<?> c2) {
> 47:         if (c1 == null) {

I'd like to ask why we have these empty null checks? To silence some warnings?

-------------

PR: https://git.openjdk.java.net/jdk/pull/422


More information about the hotspot-compiler-dev mailing list