RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v5]

[Yangfei (Felix)]

Hi Andrew,

> 
> On 10/10/2020 14:09, Fei Yang wrote:
> > On Fri, 9 Oct 2020 17:35:22 GMT, Andrew Haley <aph at openjdk.org> wrote:
> >
> >> I see Linux x64 failed. However, I don't seem to be able to withdraw my
> patch approval.
> >> However, please consider it withdrawn.
> >
> > Thanks for approving this patch.
> > I checked the error messages and I think the failures were not caused by
> this patch.
> > The failures has been fixed by the following two commits:
> >     commit ec41046c5ce7077eebf4a3c265f79c7fba33d916
> >     8254348: Build fails when cds is disabled after JDK-8247536
> >     commit aaa0a2a04792d7c84150e9d972790978ffcc6890
> >     8254297: Zero and Minimal VMs are broken with undeclared
> > identifier 'DerivedPointerTable' after JDK-8253180
> >
> > The testing was triggered again automatically after I merge master and I see
> it passed now.
> 
> OK, so we're good.

Just eyeballed the latest version and witnessed two unnecessary code changes in vm_version_aarch64.cpp.
However, these does not affect functionality and I have did one extra commit to remove them.
https://github.com/openjdk/jdk/pull/207/commits/6cd27beee5262fe86b8b4be1e0bede0fbdcb8fbc

> > Do you have any comments for the discussion here?
> >     https://github.com/openjdk/jdk/pull/207#issuecomment-701243662
> >
> > Valerie Peng has checked the java security changes, i.e.
> src/java.base/share/classes/sun/security/provider/SHA3.java.
> > Do you think we need another reviewer for this patch?
> 
> If we've had a security engineer look at the shared code, we're good to go.

I think Valerie Peng only reviewed the changes for SHA3.java.
Have you checked the hotspot shared code changes? 
If not, we may need someone reviewing that part.

Thanks,
Felix