RFR: 8254369: Node::disconnect_inputs may skip precedences

Vladimir Kozlov kvn at openjdk.java.net
Wed Oct 14 23:35:10 UTC 2020


On Wed, 14 Oct 2020 16:04:32 GMT, Xin Liu <xliu at openjdk.org> wrote:

> 8254369: Node::disconnect_inputs may skip precedences

Changes requested by kvn (Reviewer).

src/hotspot/share/opto/node.cpp line 918:

> 916:   }
> 917:
> 918: #ifndef PRODUCT

This should be #ifdef ASSERT

src/hotspot/share/opto/node.cpp line 914:

> 912:   // Remove precedence edges if any exist
> 913:   // Note: Safepoints may have precedence edges, even during parsing
> 914:   for (uint i = len() - 1; i < len() && i >= req(); --i) {

i < len() check is not needed

-------------

PR: https://git.openjdk.java.net/jdk/pull/664


More information about the hotspot-compiler-dev mailing list