RFR: 8254884: Make sure jvm does not crash with Arm SVE and Vector API [v2]

Ningsheng Jian njian at openjdk.java.net
Tue Oct 20 07:46:16 UTC 2020


On Mon, 19 Oct 2020 13:01:27 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Ningsheng Jian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments from Vladimir.
>>   
>>   Change-Id: Ia484dc59f41d265972f1253193d1d7d7cb032a12
>
> src/hotspot/cpu/aarch64/aarch64_sve.ad line 897:
> 
>> 895:   predicate(UseSVE > 0 && n->in(2)->bottom_type()->is_vect()->length_in_bytes() >= 16 &&
>> 896:             (n->in(2)->bottom_type()->is_vect()->element_basic_type() == T_SHORT ||
>> 897:             (n->in(2)->bottom_type()->is_vect()->element_basic_type() == T_CHAR)));
> 
> Is it appropriate to do this reduction when element_basic_type() == T_CHAR?

Fixed. I don't think we have that support in vectorizer and vector api. Also checked NEON and x86.

-------------

PR: https://git.openjdk.java.net/jdk/pull/726


More information about the hotspot-compiler-dev mailing list