RFR: 8255049: Remove support for the hsdis decode_instructions entry point in hotspot

Fri Oct 23 08:03:40 UTC 2020

On Thu, 22 Oct 2020 17:44:09 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> This patch drops support in hotspot for hsdis plugins which only include the old decode_instructions endpoint.
>> 
>> The decode_instructions entry point in hsdis was replaced by decode_instructions_virtual[1], with support later added to allow old hsdis plugins to work, at least for the duration of JDK 8. Dropping the backwards compatibility means you'll need a hsdis built from JDK 8 sources or later, which seems a reasonable requirement at this point.
>> 
>> It's unclear if a CSR request is needed.
>> 
>> [1] https://github.com/openjdk/jdk/commit/22544e7a7c72e8779355df963e49e846f9458ce4
>> [2] https://github.com/openjdk/jdk/commit/a9c40e9df41ee06adcd7fff951dd36b6c093a24b
>
> Good.

@neliasso @vnkozlov - thanks for reviewing!

-------------

PR: https://git.openjdk.java.net/jdk/pull/807