RFR: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle [v2]

Vladimir Ivanov vlivanov at openjdk.java.net
Fri Oct 23 09:08:37 UTC 2020


On Fri, 23 Oct 2020 09:03:53 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> There is a TODO item in their `get_vm_target`-s. We can clean those up. It looks to me the caller code does not handle `NULL` result well, which means we better `fatal` ourselves before exposing `NULL` to callers and `SEGV`-ing there.
>
> Aleksey Shipilev has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Remove whitespace
>  - Simplify the whole thing
>  - Simplify, because MemberName::vmtarget already returns Method*

Looks good.

-------------

Marked as reviewed by vlivanov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/825


More information about the hotspot-compiler-dev mailing list