RFR: 8254723: add diagnostic command to write Linux perf map file [v2]
Nick Gasson
ngasson at openjdk.java.net
Mon Oct 26 06:13:40 UTC 2020
On Thu, 22 Oct 2020 02:06:25 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
>> Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update for review comments
>
> src/hotspot/share/code/codeCache.cpp line 1571:
>
>> 1569: if (!fs.is_open()) {
>> 1570: log_warning(codecache)("Failed to create %s for perf map", fname);
>> 1571: st->print_cr("Failed to create %s", fname);
>
> `st->print_cr()` is still needed? and also I've intended to replace all `print_cr()` to UL (L1587)
It's gone now.
-------------
PR: https://git.openjdk.java.net/jdk/pull/760
More information about the hotspot-compiler-dev
mailing list