RFR: 8255245: C1: Fix output of -XX:+PrintCFGToFile to open it with visualizer [v2]

Christian Hagedorn chagedorn at openjdk.java.net
Mon Oct 26 12:46:23 UTC 2020


On Fri, 23 Oct 2020 19:35:36 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move print_on definition to header file
>
> src/hotspot/share/c1/c1_LinearScan.cpp line 4607:
> 
>> 4605: 
>> 4606: #ifndef PRODUCT
>> 4607: void Interval::print_on(outputStream* out) const {
> 
> I suggest moving the impl of print_on to the declaration in the hpp-file. That will make it easier to see at a glance how the different print methods delegate to each other.

That's a good idea - fixed it!

-------------

PR: https://git.openjdk.java.net/jdk/pull/837


More information about the hotspot-compiler-dev mailing list