RFR: 8255553: [PPC64] Introduce and use setbc and setnbc P10 instructions

[Ziviani]

On Thu, 29 Oct 2020 11:22:34 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> - setbc RT,BI: sets RT to 1 if CR(BI) is 1, otherwise 0.
>> - setnbc RT,BI: sets RT to -1 if CR(BI) is 1, otherwise 0.
>> Ref: PowerISA 3.1, page 129.
>> 
>> These instructions are particularly interesting to improve the following
>> pattern `(src1<src2)? -1: ((src1>src2)? 1: 0)`, which can be found in
>> `instruct cmpL3_reg_reg_ExEx()@ppc.ad`, by removing its branches.
>> 
>> Long.toString, that generate such pattern in getChars, has showed a
>> good performance gain by using these new instructions.
>> 
>> Example:
>> for (int i = 0; i < 200_000; i++)
>>   res = Long.toString((long)i);
>> 
>> java -Xcomp -XX:CompileThreshold=1 -XX:-TieredCompilation TestToString
>> 
>> Without setbc (average): 0.1178 seconds
>> With setbc (average): 0.0396 seconds
>
> Hi Jose,
> thanks for improving this. Looks correct. I have some ideas to share:
> Note that it's also possible to implement it branch free for < Power10: See LIR_Assembler::comp_fl2i in c1_LIRAssembler_ppc.cpp.
> This could also be used for C2 with flagsRegCR0. Maybe you would like to clean up the existing C2 code and remove the old cmovI_conIvalueMinus1_conIvalue0_conIvalue1_Ex and cmovI_conIvalueMinus1_conIvalue1?
> You could also optimize C1 and the template interpreter (TemplateTable::lcmp + float_cmp, but interpreter is not so critical) for Power10.
> But we can also just take your C2 improvement for Power10 if you don't have time for additional parts.

@TheRealMDoerr Hallo!!!
Thanks for reviewing and for your suggestion (I really appreciate it, I'm discovering more parts of C1). I'm implementing it and will send a patch.
Do you prefer me to create another task to handle that or do you prefer these changes in this same task?

-------------

PR: https://git.openjdk.java.net/jdk/pull/907