RFR: 8255565: [Vector API] Add missing format strings for extract instructs in x86.ad

Jie Fu jiefu at openjdk.java.net
Fri Oct 30 06:51:43 UTC 2020


On Thu, 29 Oct 2020 02:07:03 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> Extract instructs in x86.ad like extractI/vextractI/extractL missed the format strings (format %{ ... %}).
> When analyzing or debugging with PrintOptoAssembly, it's hard to map the generated assembly code to the MachNode instructs without the format strings.
> So it would be better to fix it.
> 
> Thanks a lot.
> Best regards,
> Jie

> Hi @DamonFool , thanks for fixing these, format string gets emitted for debug builds with +PrintOptoAssembly, few of them are muti-match patterns, may be introducing a new format specifier like %t which is replaced by BasicType of ideal node through ADLC extension could make it more clear.
> 
> LGTM

Thanks @jatin-bhateja for your review.

May I get one more review from a reviewer?
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/920


More information about the hotspot-compiler-dev mailing list