[16] RFR(S): 8250668: Clean up method_oop names in adlc

Christian Hagedorn christian.hagedorn at oracle.com
Thu Sep 3 07:41:53 UTC 2020


Hi Cesar

Looks good to me but I have not tested the additional architectures. 
Would be good if someone else could verify that.

A small comment about existing code you touched (can be updated inline, 
no new webrev required):
- s390.ad: A space is missing before the comment on L2466 and 2469

Best regards,
Christian


On 02.09.20 23:26, Cesar Soares Lucas wrote:
> Gentle ping. Can anyone PTAL?
> ------------------------------------------------------------------------
> *From:* hotspot-compiler-dev 
> <hotspot-compiler-dev-retn at openjdk.java.net> on behalf of Cesar Soares 
> Lucas <Divino.Cesar at microsoft.com>
> *Sent:* August 27, 2020 12:36 PM
> *To:* hotspot-compiler-dev at openjdk.java.net 
> <hotspot-compiler-dev at openjdk.java.net>
> *Cc:* Brian Stafford <Brian.Stafford at microsoft.com>; Aditya Mandaleeka 
> <adityam at microsoft.com>; Christian Hagedorn <christian.hagedorn at oracle.com>
> *Subject:* [16] RFR(S): 8250668: Clean up method_oop names in adlc
> Hi there,
> 
> RFE: 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8250668&data=02%7C01%7CDivino.Cesar%40microsoft.com%7Cd5d3da94303a45a0e23a08d84ac08aea%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637341538114359103&sdata=bNhB3hNulOzo5umJL93i5rkVwOA%2B0RWFEWKODMIyFcE%3D&reserved=0 
> <https://urldefense.com/v3/__https://nam06.safelinks.protection.outlook.com/?url=https*3A*2F*2Fbugs.openjdk.java.net*2Fbrowse*2FJDK-8250668&data=02*7C01*7CDivino.Cesar*40microsoft.com*7Cd5d3da94303a45a0e23a08d84ac08aea*7C72f988bf86f141af91ab2d7cd011db47*7C1*7C0*7C637341538114359103&sdata=bNhB3hNulOzo5umJL93i5rkVwOA*2B0RWFEWKODMIyFcE*3D&reserved=0__;JSUlJSUlJSUlJSUlJSUl!!GqivPVa7Brio!Ih6FuXwpcsWfgoea3sa1T1otS-K5GZjunl76Py2Dd1KIYh0i1GKV_jDasn-6y7PjH4z8rA$>
> Webrev: 
> https://nam06.safelinks.protection.outlook.com/?url=https:%2F%2Fcr.openjdk.java.net%2F~adityam%2Fcesar%2F8250668%2F0%2F&data=02%7C01%7CDivino.Cesar%40microsoft.com%7Cd5d3da94303a45a0e23a08d84ac08aea%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637341538114359103&sdata=TLIvb7p9QAnjNw7IEmjQLIUIiUnl51repMl62szUo%2F0%3D&reserved=0 
> <https://urldefense.com/v3/__https://nam06.safelinks.protection.outlook.com/?url=https:*2F*2Fcr.openjdk.java.net*2F*adityam*2Fcesar*2F8250668*2F0*2F&data=02*7C01*7CDivino.Cesar*40microsoft.com*7Cd5d3da94303a45a0e23a08d84ac08aea*7C72f988bf86f141af91ab2d7cd011db47*7C1*7C0*7C637341538114359103&sdata=TLIvb7p9QAnjNw7IEmjQLIUIiUnl51repMl62szUo*2F0*3D&reserved=0__;JSUlfiUlJSUlJSUlJSUlJSUl!!GqivPVa7Brio!Ih6FuXwpcsWfgoea3sa1T1otS-K5GZjunl76Py2Dd1KIYh0i1GKV_jDasn-6y7OU4FukqQ$>
> Need sponsor: Yes
> Tested on: Windows/Linux/MacOS tiers 1-3
> 
> can I please get some reviews for the Webrev linked above? The work
> consists of renaming "method_oop" ocurrences all around the code
> base to just "method". I've tested this on x86_64 only​* Can someone
> please help testing on other architectures as well: x86_32, PPC,
> ARM32/64, S390?
> 
> 
> Thank you,
> Cesar


More information about the hotspot-compiler-dev mailing list