RFR: 8251464: make Node::dump(int depth) support indent

[Andrew Dinn]

Hi Tobias/Xin

On 04/09/2020 10:09, Tobias Hartmann wrote:
> thanks for making these changes. That looks good to me.
> But lets wait for some more opinions from other reviewers.
I'll start by noting that this is not a review, merely user feedback.

I use node dumps a lot when debugging C2 and, looking at the supplied
example, I don't find the indentation helpful -- in fact, I actually
find it slightly disrupts my reading the graph.

Also, most of the time I feed graph dumps through a sort process so that
nodes end up listed in id order, making it easier to track chains of
links in both directions. That re-ordering makes the indentation much
less useful.

Of course, this is only a report of my way of working. I'm not against
the patch per se, so long as it is easy to disable indentation (or have
emacs remove it).

regards,


Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill