RFR(T) : 8252778 : remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
Igor Ignatyev
igor.ignatyev at oracle.com
Fri Sep 4 16:13:40 UTC 2020
thanks for your review, Katya.
@list,
can I get a Review?
Cheers,
-- Igor
> On Sep 3, 2020, at 2:16 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>
> Looks good.
>
> -katya
>
> On 9/3/20 11:40 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8252778/webrev.00/
>>> 2 lines changed: 0 ins; 1 del; 1 mod;
>> Hi all,
>> could you please review this small and trivial cleanup?
>> from JBS:
>>> `compiler/c2/stemmer` test uses `jdk.test.lib.FileInstaller` to copy "words" file from the test source directory to the current working directory, `compiler.c2.stemmer.Stemmer` can read this file. yet, `c.c.s.Stemmer` class treats its 1st argument as a path to the file, given this isn't needed and we can pass "${test.src}/words" instead of "words"
>> testing: compiler/c2/stemmer on {linux,windows,macos}-x64
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8252778
>> webrev: http://cr.openjdk.java.net/~iignatyev//8252778/webrev.00/
>> Thanks,
>> -- Igor
>
More information about the hotspot-compiler-dev
mailing list