RFR: 8252774: remove jdk.test.lib.FileInstaller action from graalunit tests

Igor Ignatyev iignatyev at openjdk.java.net
Sun Sep 6 16:50:38 UTC 2020


On Sun, 6 Sep 2020 16:37:47 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> [pre-Skara RFR](https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039874.html)
> Hi all,
> 
> could you please review this small and trivial clean up in `test/hotspot/jtreg/compiler/graalunit`?
> from [JBS](https://bugs.openjdk.java.net/browse/JDK-8252774):
>> `test/hotspot/jtreg/compiler/graalunit` tests use `jdk.test.lib.FileInstaller` to copy `ProblemList-graal.txt` from
>> `test/hotspot/jtreg/` to the current working directory as `ExcludeList.txt`, and then run
>> `compiler.graalunit.common.GraalUnitTestLauncher` w/ `-exclude ExcludeList.txt`.
> 
> `j.t.l.FileInstaller` actions aren't needed as `c.g.c.GraalUnitTestLauncher` interpeters `-exclude`'s value as path to
> file (as oppose to the file name in current directory), so we can use `${test.root}/ProblemList-graal.txt` instead of
> `ExcludeList.txt` there.
> the patch modifies `generateTests.sh` to use `${test.root}/ProblemList-graal.txt`, cleans it up (removes trailing
> spaces, empty `@summary` tag, and redundant explicit `@build`) and regenerates graalunit tests.
> testing: `test/hotspot/jtreg/compiler/graalunit` on {linux,windows,macos}-x64

> @iignatev This change now passes all automated pre-integration checks. ...

no, it's not. `epavlova` isn't a Reviewer in JDK project, so this PR and #33 aren't ready to be integrated. @edvbld ,
@rwestberg, could you please take a look?

-------------

PR: https://git.openjdk.java.net/jdk/pull/34


More information about the hotspot-compiler-dev mailing list