RFR(S): 8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks

Schmidt, Lutz lutz.schmidt at sap.com
Mon Sep 7 08:02:08 UTC 2020


Hi Tobias, 

thanks a lot for the review. And sorry for my delayed response. I was out of home office for a few days. 

Best Regards,
Lutz

On 03.09.20, 14:18, "Tobias Hartmann" <tobias.hartmann at oracle.com> wrote:

    Hi Lutz,

    looks good to me.

    Best regards,
    Tobias

    On 26.08.20 17:18, Schmidt, Lutz wrote:
    > Dear all, 
    > 
    > may I please request reviews for this small enhancement? Instead of calling a method doing complicated and fancy (hard to understand) checks, the iteration over all nmethods is now protected by holding the Compile_lock in addition to the CodeCache_lock.
    > 
    > Bug:    https://bugs.openjdk.java.net/browse/JDK-8250635
    > Webrev: https://cr.openjdk.java.net/~lucy/webrevs/8250635.00/
    > 
    > Thank you!
    > Lutz
    > 
    > 



More information about the hotspot-compiler-dev mailing list