Crashes on ppc/s390 after 8231441: AArch64: Initial SVE backend support

[Ningsheng Jian]

Hi Goetz,

Thanks for taking care of this. I will mark https://bugs.openjdk.java.net/browse/JDK-8252855 as duplicate.

Thanks,
Ningsheng

________________________________
From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Sent: Monday, September 7, 2020 5:46 PM
To: Ningsheng Jian <Ningsheng.Jian at arm.com>; hotspot-compiler-dev at openjdk.java.net <hotspot-compiler-dev at openjdk.java.net>
Cc: aarch64-port-dev at openjdk.java.net <aarch64-port-dev at openjdk.java.net>
Subject: RE: Crashes on ppc/s390 after 8231441: AArch64: Initial SVE backend support

Hi Ningsheng,

I also opened an issue for this:
https://bugs.openjdk.java.net/browse/JDK-8252846

So far, your proposed fix helps, I now put it into our testing queue.

I would already have posted the webrev, but I guess I need to do it
with skara ... where I first have to look at the new tooling.

Best regards
  Goetz.


-----Original Message-----
From: Lindenmaier, Goetz
Sent: Montag, 7. September 2020 09:07
To: Ningsheng Jian <Ningsheng.Jian at arm.com>; hotspot-compiler-dev at openjdk.java.net
Cc: aarch64-port-dev at openjdk.java.net
Subject: RE: Crashes on ppc/s390 after 8231441: AArch64: Initial SVE backend support

HI,

Thanks for the hint!  Sounds good, I'll give it a try.

... I removed some emails to reduce traffic.

Best regads,
  Goetz.

-----Original Message-----
From: Ningsheng Jian <Ningsheng.Jian at arm.com>
Sent: Montag, 7. September 2020 08:51
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Andrew Dinn <adinn at redhat.com>; hotspot-compiler-dev at openjdk.java.net; build-dev at openjdk.java.net; Vladimir Ivanov <vladimir.x.ivanov at oracle.com>; Erik Österlund <erik.osterlund at oracle.com>
Cc: aarch64-port-dev at openjdk.java.net; Doerr, Martin <martin.doerr at sap.com>
Subject: RE: Crashes on ppc/s390 after 8231441: AArch64: Initial SVE backend support

Hi Goetz,

I am sorry about that and thanks for helping to identify the issue.

As I cannot reproduce this on x86 and AArch64, a quick guess is that I may have missed the code like:

diff --git a/src/hotspot/share/opto/type.cpp b/src/hotspot/share/opto/type.cpp
index 2f4047dfa8e..f7d2f5b2320 100644
--- a/src/hotspot/share/opto/type.cpp
+++ b/src/hotspot/share/opto/type.cpp
@@ -62,12 +62,14 @@ const Type::TypeInfo Type::_type_info[Type::lastype] = {
   { Bad,             T_ARRAY,      "array:",        false, Node::NotAMachineReg, relocInfo::none          },  // Array

 #if defined(PPC64)
+  { Bad,             T_ILLEGAL,    "vectora:",      false, Op_VecA,              relocInfo::none          },  // VectorA.
   { Bad,             T_ILLEGAL,    "vectors:",      false, 0,                    relocInfo::none          },  // VectorS
   { Bad,             T_ILLEGAL,    "vectord:",      false, Op_RegL,              relocInfo::none          },  // VectorD
   { Bad,             T_ILLEGAL,    "vectorx:",      false, Op_VecX,              relocInfo::none          },  // VectorX
   { Bad,             T_ILLEGAL,    "vectory:",      false, 0,                    relocInfo::none          },  // VectorY
   { Bad,             T_ILLEGAL,    "vectorz:",      false, 0,                    relocInfo::none          },  // VectorZ
 #elif defined(S390)
+  { Bad,             T_ILLEGAL,    "vectora:",      false, Op_VecA,              relocInfo::none          },  // VectorA.
   { Bad,             T_ILLEGAL,    "vectors:",      false, 0,                    relocInfo::none          },  // VectorS
   { Bad,             T_ILLEGAL,    "vectord:",      false, Op_RegL,              relocInfo::none          },  // VectorD
   { Bad,             T_ILLEGAL,    "vectorx:",      false, 0,                    relocInfo::none          },  // VectorX

Could you please help to have a try?

Thanks,
Ningsheng


> -----Original Message-----
> From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Sent: Monday, September 7, 2020 2:35 PM
> To: Ningsheng Jian <Ningsheng.Jian at arm.com>; Andrew Dinn <adinn at redhat.com>;
> hotspot-compiler-dev at openjdk.java.net; build-dev at openjdk.java.net; Vladimir
> Ivanov <vladimir.x.ivanov at oracle.com>; Erik Österlund <erik.osterlund at oracle.com>
> Cc: aarch64-port-dev at openjdk.java.net; Doerr, Martin <martin.doerr at sap.com>
> Subject: Crashes on ppc/s390 after 8231441: AArch64: Initial SVE backend support
>
> Hi
>
> Since that change was pushed, the vm crashes in the build:
>
> To suppress the following error report, specify this argument # after -XX: or
> in .hotspotrc:  SuppressErrorAt=/type.cpp:1022 # # A fatal error has been detected by
> the Java Runtime Environment:
> #
> #  Internal Error (/usr/work/... /share/opto/type.cpp:1022), pid=28717, tid=28983 #
> assert(_type_info[base()].dual_type != Bad) failed: implement with v-call # # JRE
> version: OpenJDK Runtime Environment (16.0.0.1) (fastdebug build 16.0.0.1-
> internal+0-adhoc.openjdk.jdk)
> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 16.0.0.1-internal+0-
> adhoc.openjdk.jdk, mixed mode, tiered, compressed oops, g1 gc, linux-ppc64) #
> Problematic frame:
> # V  [libjvm.so+0x1bfe22c]  Type::xdual() const+0xfc # # No core dump will be written.
> Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited"
> before starting Java again
>
> Do you have an ad-hoc idea of the problem?
>
> I locally backed out the change which fixed the issue.
>
> Best regards,
>   Goetz.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.