RFR: 8251152: ARM32: jtreg c2 Test8202414 test crash
Filipp Zhinkin
filipp.zhinkin at gmail.com
Mon Sep 7 11:26:49 UTC 2020
Hi Christoph,
thanks for the review!
I've created pull request on github for this change:
https://github.com/openjdk/jdk/pull/48
Webrev: https://openjdk.github.io/cr/?repo=jdk&pr=48&range=00
Thanks,
Filipp.
On Sat, 5 Sep 2020 at 23:49, Langer, Christoph <christoph.langer at sap.com>
wrote:
> Hi,
>
> > > updated webrev:
> > http://cr.openjdk.java.net/~bulasevich/fzhinkin/8251152/webrev.2/
> > <http://cr.openjdk.java.net/~bulasevich/fzhinkin/8251152/webrev.2/>
> (I've
> > updated years in the copyright).
> >
> > I don't know the format used in SAP copyright notices, so I can't really
> tell if
> > you should have added ", 2020" there, this I'd suggest you to seek
> comments
> > from SAP folks.
>
> As for the SAP copyright, the webrev looks perfect For the SAP
> copyright notice, we don't append a comma after the trailing year.
>
> Best regards
> Christoph
>
>
More information about the hotspot-compiler-dev
mailing list