RFR(M): 8219586: CodeHeap State Analytics processes dead nmethods

[Schmidt, Lutz]

Hi Erik, 

thanks a lot for your review and a big thank you for your help and patience to get the matter forward and to a solution. 

Regards, 
Lutz

On 08.09.20, 16:31, "Erik Österlund" <erik.osterlund at oracle.com> wrote:

    Hi Lutz,

    This looks great, thanks for fixing this!

    Thanks,
    /Erik

    On 2020-08-26 17:20, Schmidt, Lutz wrote:
    > Dear all,
    >
    > may I please request reviews for this fix/improvement to CodeHeap State Analytics. Explained in a nutshell it removes the last holes through which the analysis code could potentially access memory which is no longer associated with the entity being inspected.
    >
    > There has been a long-lasting, off-list discussion with Erik Österlund until all pitfalls were identified and agreeable solutions were found. The important parts of that discussion are reflected in the bug comments. There are two major changes:
    >
    >   1) All accesses to the CodeHeap are now protected by continuously holding the CodeCache_lock and, in addition, the Compile_lock. Information is aggregated in local data structures for later printing without holding the above locks.
    >
    >   2) Printing the names of all code blobs has been disabled except for one operation mode where the locks can be held while printing.
    >
    > Bug:    https://bugs.openjdk.java.net/browse/JDK-8219586
    > Webrev: https://cr.openjdk.java.net/~lucy/webrevs/8219586.02/
    >
    > This change has JDK-8250635 (currently out for review) as a prerequisite. It will not compile without.
    >
    > Thank you!
    > Lutz
    >