RFR(M): 8219586: CodeHeap State Analytics processes dead nmethods

Schmidt, Lutz lutz.schmidt at sap.com
Wed Sep 9 20:14:40 UTC 2020


Hi Tobias,

thanks for the review! I'll post a pull request as soon as I can handle Git and Skara commands.

Best Regards,
Lutz

On 08.09.20, 14:06, "Tobias Hartmann" <tobias.hartmann at oracle.com> wrote:

    Hi Lutz,

    On 07.09.20 14:40, Schmidt, Lutz wrote:
    > Hi Tobias,
    > 
    > I used the brackets for "optical separation", to emphasize what was added. There is no "hidden purpose".
    > 
    > The comment attempts to explain why these fields are first initialized with NULL/false, although they are filled with "more meaningful" data shortly after.

    Okay, thanks for the explanation.

    > I will remove the brackets and try to express my thoughts more clearly by rephrasing the comment.
    > 
    > May I then regard this change as reviewed?

    Yes, looks good to me.

    Best regards,
    Tobias



More information about the hotspot-compiler-dev mailing list