RFR: 8252898: remove bulk registration of JFR CompilerPhaseType names [v2]
Vladimir Kozlov
kvn at openjdk.java.net
Sat Sep 12 01:09:40 UTC 2020
On Tue, 8 Sep 2020 21:05:21 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> The changes made in [JDK-8193210](https://bugs.openjdk.java.net/browse/JDK-8193210) support only [bulk
>> registration](https://github.com/openjdk/jdk/blob/4e6a4af1866d0007d368b78bf78b6a8e1c8be425/src/hotspot/share/compiler/compilerEvent.hpp#L75)
>> of compiler phase names with JFR. However, Graal only registers compiler phase names upon first execution of the phase
>> since the set of phases is not known during VM initialization. This means registration of a Graal phase name needs to
>> do unnecessary work, wrapping a single name into an array to conform to the bulk registration API. This pull request
>> updates the registration API to be in terms of a registering a single phase name.
>
> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental
> views will show differences compared to the previous content of the PR.
Looks good.
I ran jfr/event/compiler tests with changes and they passed except TestCompilerInlining.java which failed before
changes.
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/77
More information about the hotspot-compiler-dev
mailing list