[16] RFR(S): 8250668: Clean up method_oop names in adlc

[Cesar Soares Lucas]

Hi, thank you all for the reviews & testing. I was away on vacation but now I can get back on this.

Lindenmaier, can you please share the results of your tests?

AFAIU, now that Openjdk moved to GitHub I should proceed to opening a Pull Request there instead of updating the Webrev, right?
________________________________
From: Tobias Hartmann <tobias.hartmann at oracle.com>
Sent: September 3, 2020 6:29 AM
To: Cesar Soares Lucas <Divino.Cesar at microsoft.com>; hotspot-compiler-dev at openjdk.java.net <hotspot-compiler-dev at openjdk.java.net>
Cc: Brian Stafford <Brian.Stafford at microsoft.com>; Aditya Mandaleeka <adityam at microsoft.com>; Christian Hagedorn <christian.hagedorn at oracle.com>
Subject: Re: [16] RFR(S): 8250668: Clean up method_oop names in adlc

Hi Cesar,

looks good to me.

constantPool.hpp:498 "Method" -> "Methods"

Best regards,
Tobias

On 27.08.20 21:36, Cesar Soares Lucas wrote:
> Hi there,
>
> RFE: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8250668&data=02%7C01%7CDivino.Cesar%40microsoft.com%7C6ae31c84e1e342f3bb0d08d8500dbbae%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637347367198983514&sdata=6g9FfaOtypFidx%2Fdib5Tu0OsW6zkP9pZT82sZZ5PdzU%3D&reserved=0
> Webrev: https://nam06.safelinks.protection.outlook.com/?url=https:%2F%2Fcr.openjdk.java.net%2F~adityam%2Fcesar%2F8250668%2F0%2F&data=02%7C01%7CDivino.Cesar%40microsoft.com%7C6ae31c84e1e342f3bb0d08d8500dbbae%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637347367198983514&sdata=Z3RsgcW%2FQA9bbyTLveXv8WsQ7xDx2iz7OPY5Aqgvi04%3D&reserved=0
> Need sponsor: Yes
> Tested on: Windows/Linux/MacOS tiers 1-3
>
> can I please get some reviews for the Webrev linked above? The work
> consists of renaming "method_oop" ocurrences all around the code
> base to just "method". I've tested this on x86_64 only​* Can someone
> please help testing on other architectures as well: x86_32, PPC,
> ARM32/64, S390?
>
>
> Thank you,
> Cesar
>