RFR: 8253002: Remove the unused SafePointNode::_oop_map field [v2]

[Jorn Vernee]

On Mon, 14 Sep 2020 13:19:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments:
>>   - Remove comment in SafePointNode
>>   - Remove forward declaration of class OopMap
>
> There is also a forward declaration of `class OopMap;` in `callnode.hpp`, do we still need it?

@shipilev Thanks for the review!

> There is also a forward declaration of class OopMap; in callnode.hpp, do we still need it?

Doesn't look like it, good catch!

> I don't think we need this comment. I think it would bitrot eventually. It seems the code to construct OopMap is easily
> discoverable already.

Yeah, good point, I've removed it.

I've ran a build on Windows and Linux (WSL). Still builds with the new changes, I hope that's enough to test them.

-------------

PR: https://git.openjdk.java.net/jdk/pull/109