RFR: 8252696: Loop unswitching may cause out of bound array load to be executed

Nils Eliasson neliasso at openjdk.java.net
Mon Sep 21 09:51:11 UTC 2020


On Tue, 15 Sep 2020 11:45:51 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> Review thread so far: https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039853.html

src/hotspot/share/opto/loopPredicate.cpp line 254:

> 252:       break;
> 253:     if (iff->in(1)->Opcode() == Op_Opaque4 && skeleton_predicate_has_opaque(iff)) {
> 254:       // Only need to clone range check predicates as those can be changed and duplicated by inserting
> pre/main/post loops

Is the comment still correct? It is still always a range check predicate?

-------------

PR: https://git.openjdk.java.net/jdk/pull/176


More information about the hotspot-compiler-dev mailing list