RFR: 8253447: Remove buggy code introduced by 8249451 [v2]
Jamsheed Mohammed C M
jcm at openjdk.java.net
Tue Sep 22 02:05:01 UTC 2020
> if ((thread->has_pending_exception() || thread->frames_to_pop_failed_realloc() > 0) && exec_mode !=
> Unpack_uncommon_trap) {
> assert(thread->has_pending_exception(), "should have thrown OOME/Async");
>
> introduced a buggy code checking, clearing pending exception and taking Unpack_exception route.
>
> This can have consequences as the deopt entries may have additional logic depending on bci's. and the change introduced
> in 8249451 doesn't honor deopt exception checking and forward logic. Thank you @fisk for pointing the bug in the code.
> Request for review.
Jamsheed Mohammed C M has updated the pull request incrementally with one additional commit since the last revision:
fixing the assert message too
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/292/files
- new: https://git.openjdk.java.net/jdk/pull/292/files/d81ce188..4eea9a95
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=292&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=292&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/292.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/292/head:pull/292
PR: https://git.openjdk.java.net/jdk/pull/292
More information about the hotspot-compiler-dev
mailing list