8230664: Fix TestInstanceKlassSize for PowerPC

[Doerr, Martin]

Hi,

@Jose:
Thanks for finding this issue.

@all:
The problem is that the implementations in the following files don't fit together:

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java:
public static boolean shouldStoreFingerprint()
public boolean hasStoredFingerprint()

src/hotspot/share/oops/instanceKlass.cpp:
bool InstanceKlass::should_store_fingerprint(bool is_hidden_or_anonymous)
bool InstanceKlass::has_stored_fingerprint()

That breaks it on PPC64.

Why do we require a fingerprint when built with "#if INCLUDE_AOT" and Arguments::is_dumping_archive(), but UseAOT is off?

I could live with Jose's proposal, but a consistent implementation would be much better.

Best regards,
Martin


> -----Original Message-----
> From: hotspot-compiler-dev <hotspot-compiler-dev-
> retn at openjdk.java.net> On Behalf Of joserz at linux.ibm.com
> Sent: Montag, 28. September 2020 14:35
> To: hotspot-compiler-dev at openjdk.java.net
> Cc: Langer, Christoph <christoph.langer at sap.com>
> Subject: 8230664: Fix TestInstanceKlassSize for PowerPC
> 
> Hello team!
> 
> This is an attempt to fix bug JDK-8230664. Please, could you review it?
> 
> PR: https://github.com/openjdk/jdk/pull/358
> Bug: https://bugs.openjdk.java.net/browse/JDK-8230664
> 
> Thank you very much,
> 
> Jose R Ziviani