RFR: 8253690: [PPC64] Use flag kind diagnostic for platform specific flags

Martin Doerr mdoerr at openjdk.java.net
Wed Sep 30 08:44:37 UTC 2020


On Wed, 30 Sep 2020 06:53:38 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Current platform implementation (globals_ppc.hpp) uses regular product flags for almost everything.
>> Most platform specific flags were never intended for official support. They are only there to diagnose issues and find
>> workarounds. So flag kind "diagnostic" fits better for them.
>> 
>> Note that I rearranged a couple of lines when looking at the diff.
>> My actual change is what is described here: https://bugs.openjdk.java.net/browse/JDK-8253692
>
> src/hotspot/cpu/ppc/globals_ppc.hpp line 95:
> 
>> 93:                                                                             \
>> 94:   /* Power 8: Configure Data Stream Control Register. */                    \
>> 95:   product(uint64_t, DSCR_PPC64, (uint64_t)-1,                               \
> 
> Has nothing to do with this issue. But I leave it up to you.

Just cleanup, no real change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/413


More information about the hotspot-compiler-dev mailing list