RFR: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090

Paul Hohensee phh at openjdk.java.net
Wed Sep 30 21:59:58 UTC 2020


On Wed, 30 Sep 2020 21:50:47 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> The fix for JDK-8239090 added printing of some additional CPU flags that make CPUInfoTest.java fail.
>
> I manually compared the two lists:
> 
> $ diff /tmp/f[01]
> 7c7,8
> < "avx512_vbmi2"
> ---
>> "avx512_vmbi"
>> "avx512_vmbi2"
> 29a31
>> "hv"
> 32d33
> < "mmxext"
> 
> The old list had "avx512_vbmi2" and that's replaced by
> "avx512_vmbi" and "avx512_vmbi2" in the new list.
> The new list has "hv" as a new entry.
> The old list had "mmxext" as a deleted entry.
> 
> I don't know if all that is intentional or not, but the
> test job passed so I'm approving this change.

Retroactive review:

I'd add a corresponding comment (to the one in CPUInfoTest.java) in vm_version_x86.hpp about having to keep
CPUInfoTest.java in sync with FEATURES_LIST.

The old version of vm_version_x86.cpp included both "avx512_vmbi" and "avx512_vmbi2", but did not include "hv".

-------------

PR: https://git.openjdk.java.net/jdk/pull/442


More information about the hotspot-compiler-dev mailing list