RFR: 8264223: CodeHeap::verify fails extra_hops assertion in fastdebug test [v3]

Lutz Schmidt lucy at openjdk.java.net
Thu Apr 1 07:02:24 UTC 2021


On Thu, 1 Apr 2021 01:01:19 GMT, Hui Shi <hshi at openjdk.org> wrote:

>> The change looks good to me.
>> Thank you for digging into the tricky code to understand what's happening. The previous limit (16+2*count) was purely heuristic. Obviously, you have a more pathological test case.
>
>> The change looks good to me.
>> Thank you for digging into the tricky code to understand what's happening. The previous limit (16+2*count) was purely heuristic. Obviously, you have a more pathological test case.
> 
> Thanks! The entire CodeHeap optimization is great!

You will need a second review before the fix can be integrated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3212


More information about the hotspot-compiler-dev mailing list