RFR: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested

Nils Eliasson neliasso at openjdk.java.net
Tue Apr 6 06:50:33 UTC 2021


On Tue, 6 Apr 2021 05:55:08 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> DebugNonSafepoints should be set when PrintAssembly is requested. This only happened for compile commands but not for compiler directives. This PR moves the check to compiler directives - that code path is used for both directives and commands. I am leaving the check and update in arguments.cpp - there might be some need for using flag PrintAssembly for stubs or wrappers, in a code path that doesn't use commands or directives.
>
> Looks good.

Thanks for the reviews Vladimir and Tobias!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3316


More information about the hotspot-compiler-dev mailing list