RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v2]

[Igor Ignatyev]

On Fri, 16 Apr 2021 01:08:28 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust whitelist
>
> test/lib/jdk/test/lib/hotspot/ir_framework/TestFramework.java line 367:
> 
>> 365: 
>> 366:         for (Class<?> helperClass : helperClasses) {
>> 367:             TestRun.check(!this.helperClasses.contains(helperClass), "Cannot add the same class twice: " + helperClass);
> 
> won't it be easy to use `Set` to store `helperClasses`?

you might also want to update javadoc for this method to state that there can be duplicates.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3508