RFR: 8264958: C2 compilation fails with assert "n is later than its clone"

Roland Westrelin roland at openjdk.java.net
Fri Apr 16 11:37:38 UTC 2021


On Fri, 16 Apr 2021 09:15:39 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> JDK-8229483 added logic to hoist a load that would wrongly end up in
>> an outer strip mined loop. That logic checks that it's legal to do so
>> with:
>> 
>> is_dominator(n_ctrl, x_head)
>> 
>> but that test passes for n_ctrl == x_head when it's not legal to hoist
>> the load i.e. the test we want is for strict domination. The fix I
>> propose is to add an explicit check for that case.
>
> Looks good!

@neliasso @TobiHartmann thanks for the reviews

-------------

PR: https://git.openjdk.java.net/jdk/pull/3539


More information about the hotspot-compiler-dev mailing list