RFR: 8265480: add basic JVMCI support for JEP 309: Dynamic Class-File Constants [v4]

Thu Apr 22 15:41:23 UTC 2021

On Thu, 22 Apr 2021 15:31:48 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestDynamicConstant.java line 28:
>> 
>>> 26:  * @requires vm.jvmci
>>> 27:  * @summary Test CONSTANT_Dynamic resolution by HotSpotConstantPool.
>>> 28:  * @modules java.base/jdk.internal.org.objectweb.asm
>> 
>> Instead of ASM, I would have preferred to use `test.java.lang.invoke.lib.InstructionHelper` like `CondyBSMInvocation` [does](https://github.com/openjdk/jdk/blob/05a764f4ffb8030d6b768f2d362c388e5aabd92d/test/jdk/java/lang/invoke/condy/CondyBSMInvocation.java#L56). However, I could not figure out how to use a test library from the `test/jdk` suite in the `test/hotspot/jtreg` suite. Do you know if that's possible @PaulSandoz ?
>
> It might be (depending of source locations). I would need to look in more detail. I can do that as a follow on investigation/fix if need be, rather than block this PR?

No need to spend time on this - just thought you may know off the top of your head. I'll investigate further myself.
Thanks for the detailed review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3578